jiriOndrusek-agent commented on PR #132:
URL:
https://github.com/apache/camel-upgrade-recipes/pull/132#issuecomment-6168469748
Thanks, all points from the review check out. I re-ran it at `c6dcbe8`: the
langchain4j-tools removal now completes in a single cycle, the irc and SB-422
tests are fixed, and pqc passed 15/15. A few new things:
1. **Blocking:** after the Spring Boot 4.1.1 bump, 3 tests still expect
4.1.0 and fail, with or without Camel 4.23.0:
- `CamelSpringBoot422Test#migrateAiToolStarterDependency` (L122)
- `CamelSpringBoot422Test#aiToolStarterIsNotDuplicated` (L180)
- `CamelSpringBootBomVersionTest#propertyManagedBomIsUpdated` (L87)
2. `CamelUpdate418LtsTestSuite` doesn't list `CamelUpdate418_4Test` and
`CamelUpdate418_5Test`, so the new LTS wiring isn't tested in the suite. Its
javadoc still says 4.18.3.
3. `camel422.migrateAtmosphereWebsocketHeaders` shipped in recipes 4.22.0
and is now removed, so direct `activeRecipes` references break. Maybe keep a
one-line alias?
4. Release notes:
- The 4.18.5 row lists netty-http (CAMEL-25376) and undertow WebSocket
(CAMEL-25375), but both are in 4.18.6. It misses the camel-hazelcast change,
which is in 4.18.5.
- The 4.22.2 row misses camel-lra (×2) and camel-telegram.
5. Nit, `4.23.yaml:403-405`: the joor reason "do not share options" doesn't
hold. `JoorLanguage extends JavaLanguage` and has no setters of its own, so
`camel.language.joor.*` → `camel.language.java.*` is a 1:1 rename. That also
contradicts the release notes (L47).
I couldn't re-run the 4.23.0-dependent tests: staging isn't reachable and
4.23.0 isn't on Central yet. I'll re-check the `SB423` starter tests once it's
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
