christophd commented on PR #27792: URL: https://github.com/apache/camel/pull/27792#issuecomment-6185912337
_Claude Code on behalf of Christoph Deppisch_ Hi @davsclaus @gnodet-bot — thank you for the thorough review! We've pushed a significant architecture change based on your feedback: **Key change:** `CitrusEndpoint` now **extends `MockEndpoint`** instead of using a custom `CitrusProducer` with manual state management. This resolved many of the concerns raised: - All MockEndpoint features (context-wide `assertIsSatisfied`, `resetMocks`, built-in expectations) work out of the box - Custom `expectedMessageCount`, latch, counter, and volatile field management has been removed — delegated to the superclass - Citrus validation is dispatched via MockEndpoint's `whenExchangeReceived()` / `whenAnyExchangeReceived()` processor infrastructure - `CitrusProducer` has been replaced by `CitrusValidationProcessor` (a `Processor`, not a `Producer`) - Failure reporting uses a `performAssertions()` override to capture exceptions from `tryProcessing()` into the failures list - The Gherkin-style API has been simplified to a fluent `when().receive().body().then().respond().body()` chain I've replied to each review comment individually with the current status. All comments have been addressed, either directly or by the architecture change making them no longer applicable. Would you kindly have another look at the updated changeset? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
