christophd commented on PR #1817: URL: https://github.com/apache/camel-website/pull/1817#issuecomment-6186254498
Thanks for the thorough review! Here's what we addressed: **Factual issues** 1. **`camel test list` does not exist** — replaced with `camel test inspect` and `camel test ps` in the command table. 2. **Log verification example doesn't match the route** — changed `"Order validation successful"` to `"VALIDATED — order ORD-001"` to match the route's actual log output. 3. **`kaoto-designer.png` shows a `compose-up` step** — updated the screenshot to reflect the current `camel.infra.run` approach. 4. **`# deps:` comment unexplained** — replaced with `Automatic (via JBang)` in the comparison table. 5. **Example repo layout claim** — removed the false claim about `quarkus/`, `spring-boot/`, `yaml-dsl/` subdirectories; reworded to a general statement about the repository. **Minor** - Added a note explaining `camel.cli` vs `camel.jbang` naming (both supported in Citrus 5.0.1+, `camel.cli` preferred). - Softened "A thorough test covers all of them" to "covers four of them" since missing `orderId` is not in the test. - Fixed inconsistent test name: `OrderValidationTest` → `order-validation-test` in the first snippet. - Changed `categories: ["Testing"]` → `["Howtos", "Tooling"]` to use existing categories. - Updated PR description to say `camel.infra.run` instead of "Docker Compose via Testcontainers". - Updated `kaoto-online.png` screenshot. **New content** - Added two paragraphs in "How YAML tests relate to Java-based testing" about: (1) `camel export` preserving YAML tests when exporting to a Java project, and (2) Citrus supporting both YAML and Java DSL on JUnit Jupiter with Spring Boot/Quarkus integration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
