apupier opened a new pull request, #27903:
URL: https://github.com/apache/camel/pull/27903
Seven FTP consumer IT tests were susceptible to receiving more messages than
expected because:
1. The Camel context and routes are started *before* doPostSetup() runs, so
the FTP consumer scheduler can fire its first poll against an empty or
partially-populated directory.
2. Without idempotency protection (no noop/delete/idempotent), files are
re-consumed on every subsequent poll interval within the
MockEndpoint.assertIsSatisfied() 10-second wait window, causing "expected <N>
but was <M>" assertion failures non-deterministically.
Fix: add &noop=true to all affected consumer URLs. noop=true automatically
enables idempotent=true, so each file path is tracked in a
MemoryIdempotentRepository and consumed exactly once regardless of how many
poll cycles occur during the test.
A separate getFtpProducerUrl() helper is introduced in each test where
sendFile() previously reused getFtpUrl(). This prevents consumer-only options
(noop, recursive, include, filter, sorter, sortBy) from leaking into producer
URLs, which would cause endpoint resolution failures.
Additionally, FtpConsumerDirectoriesNotMatchedIT now verifies the exact set
of matched file names via AssertJ after assertIsSatisfied(), giving a clear
diagnostic on failure ("expected only .txt files but got: [...]"),
and the assertj-core dependency is added to camel-ftp for this purpose.
Affected tests:
- FtpConsumerDirectoriesNotMatchedIT (original flaky test, CAMEL-25688)
- FtpConsumerRelativeFileNameIT
- FtpConsumerMultipleDirectoriesIT
- FtpConsumerSkipDotFilesIT
- FromFtpRemoteFileFilterIT
- FromFtpRemoteFileSorterIT
- FromFtpRegexPatternIT
Co-authored-by: IBM Bob 2.2.1
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
