davsclaus opened a new pull request, #27913: URL: https://github.com/apache/camel/pull/27913
A follow-up to CAMEL-25389 (#27909) for the Java source support of CAMEL-25565 (#27715), which merged after it. - The parts of a Java route the Java DSL parser could not read are now a warning on stderr (`printWarn`), as promised in a #27715 review comment. Before, the note was printed on stdout and left out with `--json`, so a partial result was silent there. Now `--json` keeps stdout one JSON document (which still lists the parts in `unread`), and the warning is on stderr either way. The `printSourceNotes()` hook is gone. - A source file of `camel cmd route-diagram`, `route-structure` and `route-topology` that does not exist ends the command with a `CliException` (exit code 3, one `ERROR:` line on stderr) instead of exit 1. This is the code every other command uses for a missing file since #27909, and these files were left out of that PR because #27715 changed the same lines. - The 4.24 upgrade guide lists both. ### Tests - `RouteActionJavaSourceTest`: the note is on stderr; the `--json` topology parses stdout alone and has the warning on stderr; a missing file is a `CliException` with code 3. - `CamelRouteDiagramActionDispatchTest`, `CamelRouteTopologyActionTest`, `CamelRouteDiagramActionMultiFileTest`: a missing file is a `CliException` with code 3. - The camel-jbang-core `action` package tests and the exit code contract tests pass. _Claude Code on behalf of davsclaus_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01DDRLJAyf8cDXSg8iX785My -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
