davsclaus commented on code in PR #27925:
URL: https://github.com/apache/camel/pull/27925#discussion_r4291167122
##########
parent/pom.xml:
##########
@@ -3894,10 +3894,13 @@
<artifactId>jakarta.xml.bind-api</artifactId>
<version>${jakarta-xml-bind-api-version}</version>
</dependency>
+ <!-- all ASM artifacts (asm, asm-commons, asm-util, asm-tree,
asm-analysis) at the same version -->
<dependency>
<groupId>org.ow2.asm</groupId>
- <artifactId>asm</artifactId>
+ <artifactId>asm-bom</artifactId>
<version>${asm-version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
Review Comment:
One small note: an imported bom loses to an import declared earlier in the
merged model, and a child's imports come before the parent's. So a module that
imports its own bom that manages ASM now takes ASM from that bom instead of
`asm-version`. In practice that is only `camel-jbang-mcp`: quarkus-bom 3.40.1
manages ASM at 9.10.1, so with main on `asm-version` 9.11 that module's `asm`
moves from 9.11 to 9.10.1. That is fine for a Quarkus app, just worth
mentioning in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
