gnodet-bot commented on code in PR #27965:
URL: https://github.com/apache/camel/pull/27965#discussion_r4298108009
##########
components/camel-vertx/camel-vertx-websocket/src/main/java/org/apache/camel/component/vertx/websocket/VertxWebsocketEndpoint.java:
##########
@@ -275,6 +274,18 @@ WebSocket getWebSocket(BiConsumer<WebSocket, Boolean>
setupCallback) throws Exce
return webSocket;
}
+ /**
+ * Gives up on a connect the caller stopped waiting for. A connect that
completes from now on closes its own
+ * WebSocket. One that completed after the wait timed out but before this
call is closed here, as nobody will use
+ * it.
Review Comment:
💡 **Suggestion:** The sentence "One that completed after the wait timed out
but before this call is closed here" is hard to parse — "before this call" is
ambiguous (method call? connect call?) and "is closed here" lacks a clear
subject.
```suggestion
* WebSocket. One that completed between the timeout and this method
call is closed here,
* since nobody will use it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
