davsclaus commented on code in PR #27935: URL: https://github.com/apache/camel/pull/27935#discussion_r4298280862
########## components/camel-hibernate/src/main/java/org/apache/camel/component/hibernate/HibernateProducer.java: ########## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hibernate; + +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import org.apache.camel.Exchange; +import org.apache.camel.Expression; +import org.apache.camel.spi.Language; +import org.apache.camel.support.DefaultProducer; +import org.apache.camel.support.SynchronizationAdapter; +import org.hibernate.KeyType; +import org.hibernate.Session; +import org.hibernate.StatelessSession; +import org.hibernate.Transaction; +import org.hibernate.query.MutationQuery; +import org.hibernate.query.SelectionQuery; + +public class HibernateProducer extends DefaultProducer { + + private final HibernateEndpoint endpoint; + private final Map<String, Object> naturalIdParameters = new LinkedHashMap<>(); + + public HibernateProducer(HibernateEndpoint endpoint) { + super(endpoint); + this.endpoint = endpoint; + } + + @Override + protected void doStart() throws Exception { + super.doStart(); + Language simple = endpoint.getCamelContext().resolveLanguage("simple"); + + naturalIdParameters.clear(); + if (endpoint.getNaturalIdParameters() != null) { + endpoint.getNaturalIdParameters().forEach((key, value) -> { + if (value instanceof String str) { + naturalIdParameters.put(key, simple.createExpression(str)); + } else { + naturalIdParameters.put(key, value); + } + }); + } + } + + private Map<String, Object> resolveNaturalIdParameters(Exchange exchange, Map<String, Object> headerParameters) { + Map<String, Object> resolved = new LinkedHashMap<>(); + + naturalIdParameters.forEach((key, value) -> { + if (value instanceof Expression expression) { + resolved.put(key, expression.evaluate(exchange, Object.class)); + } else { + resolved.put(key, value); + } + }); + + if (headerParameters != null) { + // Header values are message data and must never be evaluated as Simple expressions. + resolved.putAll(headerParameters); + } + + return resolved; + } + + @Override + public void process(Exchange exchange) throws Exception { + if (endpoint.isStreaming() && exchange.isTransacted()) { + throw new IllegalArgumentException( + "streaming=true is not supported inside a transacted exchange because streams can outlive route transactions."); + } + + if (exchange.isTransacted() && !endpoint.isJta()) { + throw new IllegalStateException( + "Hibernate producer does not support transacted() exchanges with a resource-local SessionFactory."); + } + + if (endpoint.getStatelessOperation() != null) { + processStateless(exchange); + return; + } + + HibernateSessionContext sessionContext = exchange.getExchangeExtension() + .getSafeCopyProperty(HibernateConstants.HIBERNATE_SESSION_CONTEXT, HibernateSessionContext.class); + + Session session = sessionContext == null + ? null + : sessionContext.getSession( + endpoint.getSessionFactory(), + endpoint.getTenantIdentifier(), + endpoint.getFilters()); + + boolean sessionOwned = session == null; + + if (sessionOwned) { + session = endpoint.getTenantIdentifier() == null + ? endpoint.getSessionFactory().openSession() + : endpoint.getSessionFactory().withOptions() + .tenantIdentifier(endpoint.getTenantIdentifier()) + .openSession(); + } + + final Session activeSession = session; + final Transaction transaction = sessionOwned + ? activeSession.beginTransaction() + : activeSession.getTransaction(); + + try { + if (sessionOwned && endpoint.getFilters() != null) { + endpoint.getFilters().forEach((filterName, parameters) -> { + var filter = activeSession.enableFilter(filterName); + if (parameters != null) { + parameters.forEach(filter::setParameter); + } + }); + } + + @SuppressWarnings("unchecked") + Map<String, Object> parameters = exchange.getMessage().getHeader( + HibernateConstants.HIBERNATE_PARAMETERS, Map.class); + + if (endpoint.getNaturalIdParameters() != null + && !endpoint.getNaturalIdParameters().isEmpty()) { + Object entity = activeSession.find( + endpoint.getEntityType(), + resolveNaturalIdParameters(exchange, parameters), + KeyType.NATURAL); + + exchange.getMessage().setBody(entity); + + if (sessionOwned) { + transaction.commit(); + activeSession.close(); + } + } else if (endpoint.getSelectionQuery() != null) { Review Comment: The same mismatch as the natural-id branch, one branch down: `HibernateEndpoint.doStart()` counts `selectionQuery` only when it is not blank, but this branch is taken whenever it is not `null`. An endpoint where `selectionQuery` is set but empty (for example from a property placeholder with an empty default) next to a `mutationQuery` passes validation, and then runs the empty selection query instead of the mutation. ```suggestion } else if (endpoint.getSelectionQuery() != null && !endpoint.getSelectionQuery().isBlank()) { ``` ########## components/camel-hibernate/src/main/java/org/apache/camel/component/hibernate/HibernateConsumer.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hibernate; + +import java.util.List; + +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.support.ScheduledPollConsumer; +import org.hibernate.LockMode; +import org.hibernate.Session; +import org.hibernate.Timeouts; +import org.hibernate.Transaction; +import org.hibernate.query.SelectionQuery; + +public class HibernateConsumer extends ScheduledPollConsumer { + + private final HibernateEndpoint endpoint; + + public HibernateConsumer(HibernateEndpoint endpoint, Processor processor) { + super(endpoint, processor); + this.endpoint = endpoint; + } + + @Override + protected void doStart() throws Exception { + if (endpoint.getSelectionQuery() == null || endpoint.getSelectionQuery().isBlank()) { Review Comment: Optional: nothing tests this check yet. Something like this in `HibernateEndpointTest` would pin it (an exception from `doStart()` comes out of `start()` unchanged): ```java @Test void shouldRejectConsumerWithoutSelectionQuery() { HibernateEndpoint endpoint = createEndpoint(); endpoint.setMutationQuery("update HibernateTestEntity set name = :name"); HibernateConsumer consumer = new HibernateConsumer(endpoint, exchange -> { }); assertThrows(IllegalArgumentException.class, consumer::start); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
