allthingssecurity commented on code in PR #27988:
URL: https://github.com/apache/camel/pull/27988#discussion_r4301873074
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -521,6 +521,14 @@ now resolves to no value, as it already did without a
field, so its default valu
(`{{?hashicorp:secret:missing#field}}`) applies. Before, without a default
value, it failed with a
`NullPointerException`.
+=== camel-bindy - a number field without precision keeps all its decimals when
marshalled
+
+A `BigDecimal`, `Double` or `Float` field whose `@DataField` (or
`@KeyValuePairField`) has no `precision` and no
+`pattern` was marshalled with at most three decimals, rounded: `1.23456` was
written as `1.235` and `0.000123` as `0`.
Review Comment:
Good point, thanks. Fixed in a7dac494ce24. I checked the 4.21.0 sources:
`@DataField` and `@KeyValuePairField` had `precision() default 0`, and
`AbstractNumberFormat` then set both minimum and maximum fraction digits to 0.
The sentence now reads: "...was marshalled with at most three decimals,
rounded: `1.23456` was written as `1.235` and `0.000123` as `0` (since Camel
4.22, CAMEL-24168; up to Camel 4.21 the default `precision = 0` wrote these
fields without any decimals)."
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
