gnodet-bot commented on code in PR #28027: URL: https://github.com/apache/camel/pull/28027#discussion_r4304016764
########## components/camel-alibaba/camel-alibaba-eventbridge/src/main/docs/alibaba-eventbridge-component.adoc: ########## @@ -157,12 +157,35 @@ When building routes that accept untrusted external ingress (such as HTTP endpoi To prevent untrusted callers from manipulating security policies, always sanitize or remove Camel headers before forwarding to the Alibaba EventBridge producer: +[tabs] +==== Review Comment: ⚠️ **Asciidoctor delimiter conflict: `====` inside `[IMPORTANT]`** This `[tabs]` block is nested inside an existing `[IMPORTANT]` admonition that also uses `====` as its delimiter. In Asciidoctor, `====` is a _toggle_ delimiter — the inner `====` here will **close** the outer `[IMPORTANT]` admonition instead of opening the tabs block, leaving the Java and YAML examples outside the warning box. The [asciidoctor-tabs documentation](https://github.com/asciidoctor/asciidoctor-tabs?tab=readme-ov-file#usage) explicitly recommends extending the outer block delimiter to 6 characters (`======`) to avoid this conflict. Fix: change the `[IMPORTANT]` admonition's delimiters from `====` to `======`: ```asciidoc [IMPORTANT] ====== In Apache Camel's security model... ... [tabs] ==== Java:: + [source,java] ... ==== ====== ``` The same fix is needed in the catalog copy (`catalog/.../alibaba-eventbridge-component.adoc`). The other two `[tabs]` blocks ("Publish event with String / JSON body" and "Dynamic Header and Property Overrides" sections) are **not** nested inside admonitions and are fine as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
