davsclaus commented on code in PR #28068:
URL: https://github.com/apache/camel/pull/28068#discussion_r4310716640
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -801,6 +801,15 @@ now resolves to no value, as it already did without a
field, so its default valu
(`{{?hashicorp:secret:missing#field}}`) applies. Before, without a default
value, it failed with a
`NullPointerException`.
+=== camel-aws2-ddb - aws2-ddbstream reads every shard to its end
+
+The `aws2-ddbstream` consumer now reads a closed shard to its end before it
reads the shards created from it, and uses
+`streamIteratorType` only for its start position. Before, a closed shard was
left once its child shards were listed, so
+its records that were not read yet were never routed; and when every shard it
was reading had been read to its end, the
+consumer started again from `streamIteratorType`: with `FROM_START` it routed
records of the stream again (at every poll
+when its closed root shards were read to their end in one response), with
`FROM_LATEST` it skipped the records already
+written to the new shards.
Review Comment:
Nit: the entry is correct, but the second sentence is hard to read. Maybe:
```suggestion
The `aws2-ddbstream` consumer now reads a closed shard to its end before it
reads its child shards, and uses
`streamIteratorType` only for its start position. Before, records left in a
closed shard could be skipped, and after a
shard rotation the consumer started again from `streamIteratorType`: with
`FROM_START` it routed records of the stream
again, and with `FROM_LATEST` it skipped records already written to the new
shards.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
