davsclaus commented on code in PR #28074:
URL: https://github.com/apache/camel/pull/28074#discussion_r4310711749


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -1361,6 +1361,16 @@ Previously it returned only the first chunk of the event 
log (at most 500 events
 any sign. A wide `after`/`before` window now returns every event in one list: 
that is one request per 500 events plus
 one that finds the end of the log, and more memory. Narrow the window when the 
event log is large.
 
+=== camel-aws2-eventbridge - the consumer keeps one target for a queue given 
with queueUrl
+
+A consumer that uses its own queue (`queueUrl`) added a target with a new 
random id to the EventBridge rule at every
+start, and removed it on stop. Two consumers that share the queue, or a 
restart after a consumer was not stopped
+cleanly, left two targets for the queue, and EventBridge put every event on 
the queue twice. The target now has an id
+derived from the queue ARN, and stays on the rule when the consumer stops, so 
the queue also collects the events of the
+rule while no consumer runs. Remove the target from the rule yourself when you 
no longer use the queue, and remove
+targets with ids `camel-eb-` plus 8 characters that an earlier version left 
for the queue. An auto-created queue is
+not affected.
+

Review Comment:
   Optional: during a rolling upgrade, an instance on an earlier version and 
one on this version add two different targets (`camel-eb-` + 8 random 
characters, and the hashed id), so events are put on the queue twice until the 
old instance stops and removes its target. It may be worth one sentence here, 
for example:
   
   ```suggestion
   not affected. During a rolling upgrade from an earlier version, events can 
be put on the queue twice until the last
   instance on the earlier version stops.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to