Croway commented on PR #2046:
URL:
https://github.com/apache/camel-spring-boot/pull/2046#issuecomment-6266286705
@ramu11 #28086 is merged (CAMEL-25791, in 4.24.0). Yes, your understanding
is right: registering a `StateStoreBackendFactory` instead of a global
`KeyValueRepository` resolves the optimistic-locking, `completionTimeout`,
Cache EIP TTL and per-store isolation findings.
Still to do in this PR:
- Replace the `KeyValueRepository` bean with a `StateStoreBackendFactory`
bean (`storeName -> new SpringCacheKeyValueRepository(cacheManager,
storeName)`), and drop the hard-coded `camel-kvr` default. Moving it to
`camel-state-store-starter` would avoid a new dependency in
`core/camel-spring-boot`.
- Use `@ConditionalOnSingleCandidate(CacheManager.class)`.
- Add a Redis IT as described above.
- Docs:
- remove the EIP / shared-cache / recovery sections, which no longer apply
(the recovery one was wrong anyway)
- state clearly that `keys()`/`size()` are unsupported on Caffeine, Redis
and JCache
- document per-store TTL via the provider and non-atomic CAS. Spring
`Cache` has no atomic get-and-put, so documenting it is enough.
- Fix the fully qualified class name in the Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
