gnodet-bot commented on code in PR #28111:
URL: https://github.com/apache/camel/pull/28111#discussion_r4313585214
##########
components/camel-milo/src/test/java/org/apache/camel/component/milo/MiloClientExecutorTest.java:
##########
@@ -45,6 +46,11 @@ public class MiloClientExecutorTest extends
AbstractMiloServerTest {
= "milo-client:opc.tcp://foo:bar@localhost:@@port@@?node="
+ nodeValue(MiloServerComponent.DEFAULT_NAMESPACE_URI,
"myitem1") + "&overrideHost=true";
+ // no server listens on this port
+ private static final String MILO_CLIENT_UNREACHABLE
+ = "milo-client:opc.tcp://localhost:" +
AvailablePortFinder.getNextAvailable() + "?node="
Review Comment:
💡 **Minor:** `AvailablePortFinder.getNextAvailable()` is `@Deprecated` —
prefer `AvailablePortFinder.find().getPort()` (or hold the `Port` object while
the field is live, though for an unreachable endpoint that's not strictly
necessary).
```suggestion
= "milo-client:opc.tcp://localhost:" +
AvailablePortFinder.find().getPort() + "?node="
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
