davsclaus commented on code in PR #28123:
URL: https://github.com/apache/camel/pull/28123#discussion_r4316722540
##########
core/camel-api/src/main/java/org/apache/camel/spi/PropertiesReload.java:
##########
@@ -44,4 +44,20 @@ public interface PropertiesReload {
*/
void onReload(String name, Properties properties) throws Exception;
+ /**
+ * Callback when a resource with properties changed and is re-loaded, such
as a properties file that was saved while
+ * live reloading is enabled. Unlike {@link #onReload(String,
Properties)}, the properties are only those that
+ * changed, as the user edited them, so a listener can tell which changes
it cannot apply without a restart.
+ * <p/>
Review Comment:
The new line follows the style of the file (`<p/>` on lines 24 and 28) and
of camel-api, where 187 files of this package use `<p/>` and 17 use `<p>`. So I
keep it.
One correction to the summary of the review: a reload does not re-create a
bean that exists. It creates only beans with a new name, and a change to the
properties of an existing bean logs a WARN that a restart is needed, as
components and routes may hold the bean.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
