gnodet-bot commented on PR #28106: URL: https://github.com/apache/camel/pull/28106#issuecomment-6265352633
💡 **Minor: no SNOVA level coverage in the new test** (low severity) `mayoResolvesEveryDocumentedLevel` checks all four MAYO parameter sets. SNOVA has its own set of named parameter specs in BC 1.86 (`SNOVA_24_5_5_SHAKE_SSK`, `SNOVA_37_8_4_SHAKE_SSK`, etc. — accessible via `SnovaParameterSpec.fromName()`). The PR description claims SNOVA is now fully resolvable, but the test only verifies that `SNOVA` is supported (via the parameterized `mayoAndSnovaAcceptANamedParameterSet` test) — it doesn't verify any named level actually resolves. Consider adding a `snovaResolvesEveryDocumentedLevel` test parallel to the MAYO one, asserting at minimum one or two well-known SNOVA levels resolve to a non-null `SnovaParameterSpec` instance. _This comment was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
