apupier opened a new pull request, #28112: URL: https://github.com/apache/camel/pull/28112
FutureEventDrivenOperation.watchRequestCompleted() (added by CAMEL-25655) fails the operation as soon as the asynchronous request installing the watch returns a non-OK result code, because ZooKeeper does not register the watch in that case and the awaited event would never come. However the request and the watched event are independent: when the node is deleted right after the request was sent, the NodeDeleted event can be processed first and the request then completes with NONODE. The operation had already got what it was waiting for, but the late failure was still recorded and get() threw "Could not watch node", which made DataChangedOperationIT.getsNotifiedWhenNodeIsDeleted flaky. Only record the failure when the awaited event has not been received yet. A failed request with no event received (session expired, connection loss) still fails the operation as before. FutureEventDrivenOperationTest covers both cases. Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
