davsclaus commented on code in PR #28207:
URL: https://github.com/apache/camel/pull/28207#discussion_r4333296280
##########
components/camel-azure/camel-azure-eventhubs/src/main/java/org/apache/camel/component/azure/eventhubs/EventHubsConsumer.java:
##########
@@ -250,6 +254,8 @@ private void processCommit(final Exchange exchange, final
EventContext eventCont
processedEvents.set(0);
Review Comment:
The line above still has `cnt ==
getConfiguration().getCheckpointBatchSize()`.
`EventHubsCheckpointUpdaterTask.run()` now adds the count back after a failed
checkpoint, so the count can jump past the batch size. This check needs `>=`,
as on main (CAMEL-25683).
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -1409,6 +1409,19 @@ filtering performed by other components.
Ordinary application headers are unaffected.
+=== camel-azure-eventhubs - an event that completes when the checkpoint timer
of its window has run is checkpointed
Review Comment:
This sits under "Upgrading Camel 4.21 to 4.22", but 4.22.2 is already
tagged, so the fix ships in 4.22.3. It needs a new "Upgrading from 4.22.2 to
4.22.3" section at the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
