davsclaus commented on PR #28209: URL: https://github.com/apache/camel/pull/28209#issuecomment-6311871229
@oscerd thanks for the review. Both points are in ef6567bd2150. 1. **awaitOutput javadoc:** fixed. It now says that a record of a log step is cut to 400 characters, and that a WARN or ERROR line of Camel is compacted and cut to 800. 2. **The wait when the run has its own files:** yes, it now waits only when the process watches the file. The check is cheap: `IntegrationLauncher.watchesFile` reads the command line of the process, as `runningMessage` does. It waits when the command line has `--source-dir`, names the written file (a Groovy route given as a file), has a wildcard, or cannot be read (the behavior before). Otherwise a template or script write gets its answer at once: "The running integration (pid N) was started with its own files and does not reload when this file changes; camel_control restart picks up the change." I kept the check off route files (`.yaml`, `.xml`, `.xsl`, `.properties`), so their behavior is as before: `application.properties` and other files can be watched without being on the command line, and I did not want to drop a wait that pays off. Tests: `IntegrationLauncherTest.anIntegrationStartedWithItsOwnFilesWatchesOnlyThose`, and `AuthoringToolsTest.aWriteOfATemplateTheIntegrationDoe sNotWatchIsAnsweredAtOnce`, which writes a `.ftl` with the test JVM selected and gets the answer without the 8 s wait. Tests: `AuthoringToolsTest`, `IntegrationLauncherTest` and `ReloadOutcomeTest` (45) pass. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
