gnodet-bot commented on code in PR #28231:
URL: https://github.com/apache/camel/pull/28231#discussion_r4335326431
##########
components/camel-openstack/src/main/java/org/apache/camel/component/openstack/swift/SwiftConstants.java:
##########
@@ -30,19 +29,14 @@ public final class SwiftConstants extends
OpenstackConstants {
@Metadata(label = "object", description = "The object name.", javaType =
"String")
public static final String OBJECT_NAME = "CamelOpenstackSwiftObjectName";
- // The following four constants intentionally keep the openstack4j-defined
values
- // (X-Container-Meta-, X-Versions-Location, X-Container-Read,
X-Container-Write)
- // because they are part of the Swift HTTP protocol contract used by
openstack4j
- // to forward metadata and ACL headers to the Swift backend. Renaming them
would
- // break interoperability with the Swift API.
@Metadata(label = "container", description = "Container metadata prefix.",
javaType = "Map<String, String>")
- public static final String CONTAINER_METADATA_PREFIX =
SwiftHeaders.CONTAINER_METADATA_PREFIX;
+ public static final String CONTAINER_METADATA_PREFIX =
"CamelOpenstackSwiftContainerMetadata";
Review Comment:
⚠️ **Stale description:** Now that `CONTAINER_METADATA_PREFIX` holds the
Camel Exchange header name `"CamelOpenstackSwiftContainerMetadata"` (a
`Map<String, String>` header key), the `@Metadata` description `"Container
metadata prefix."` is no longer accurate — the word "prefix" referred to the
old wire-level HTTP header prefix (`X-Container-Meta-`). Consider updating it
to `"Container metadata."` (or a more descriptive wording).
```suggestion
public static final String CONTAINER_METADATA_PREFIX =
"CamelOpenstackSwiftContainerMetadata";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
