davsclaus commented on PR #28234:
URL: https://github.com/apache/camel/pull/28234#issuecomment-6313990531
Thanks. These are addressed in 3101f3263723, after merging the updated
#28220 branch in.
**CI**: as for #28220, `Build and test` runs once this PR targets `main`,
after #28213 and #28220.
1. **Fixed.** The right edge is now `viewportWidth - 1 + hSkip`, as the last
column is the scrollbar's. `aCutNameKeepsItsEllipsisAndTheCountItsDigits`
renders 44 to 72 columns and checks that every cut name keeps its `…` and every
count its digit. Without the fix it fails at 45 columns.
2. **Done, all three:**
- A state not computed for the file shown counts as stale. For a file the
integration has no route from, the tracker keeps `Computed(file, null)`, which
is not stale. Showing another file, or saving it, computes the state at once in
the background, so the gap is a frame rather than a second. A refresh that
started later wins over one that ends after it.
- `liveLines()` reads the data again as soon as the file shown changes.
`anotherFileHasItsOwnLiveRunDataAtOnce` fails without it.
- A file whose routes are all stopped (or suspended) now has a state of
its own: `○ the routes of this file are stopped`.
- Its live run data and body types still show when the integration
loaded the file as saved. Without a reload that is known, as the routes were
loaded at the start.
- After a reload, when a stopped route was loaded is not known, so they
are left out.
- A file saved since the integration loaded it says `not running yet`,
stopped or not.
3. **Done.** The description of CAMEL-25897 now says the checksum part is
out of scope, and why, and a comment points to this PR.
4. **Intended.** ⚠ is the mark of a mixed body kind in every view (Routes,
Diagram and the Camel CLI). The types at the end of the line carry it too, in
the warning color. A line with a deprecated option takes the gutter as before,
and its body types still show the ⚠. The quick documentation of the line says
which one it is. A glyph of its own in the gutter would make the mark differ
between the views.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
