etzel-mes opened a new pull request, #28254: URL: https://github.com/apache/camel/pull/28254
# Description The follow-up agreed in the review of #28212. Since CAMEL-25692 (#28212) and CAMEL-25873 (#28219), a monitored item that the server refused is created again every `reconnectTimeout` milliseconds (10000 by default), as the WARN of the refusal already logs. This aligns the texts and the tests with it: - The milo-client component page and the 4.24 upgrade note of CAMEL-25692 said "every 10 seconds"; they now say every `reconnectTimeout` (10 seconds by default). The 4.24 note on server certificate validation said the client "tries again every 10 seconds"; connection attempts follow `reconnectTimeout` too, so it now uses the wording of the component page. - The description of the `reconnectTimeout` option named only the connection attempts; it now names the retry of refused monitored items as well (generated JSON, catalog and DSL updated). - `MonitoredItemRetryTest` and the two consumers of `CommunicationLossTest` that share the connection of the refused node set `reconnectTimeout=1000`, with waits to match: quiet periods of 15 and 12 s become 3 s, and upper bounds of 30 s become 10 s. No change in behaviour; the main code changes are javadoc only. Tests, run locally on JDK 21 with `-Dsurefire.rerunFailingTestsCount=0`: | | before | after | |---|---|---| | `MonitoredItemRetryTest` | 52 s | 13 s | | `CommunicationLossTest#refusedNodeIsCreatedOnceTheSessionIsActiveAgain` | 31 s | 30 s | In the second test the retry now creates the node within a second after the session is back. The node's value still arrives about 10 s later, because the embedded server first answers the Publish requests it had queued for the dropped channel. That queue, not the retry interval, sets the test's duration. Module `-Psourcecheck verify`: 99 tests, 0 failures, 1 skipped. Fixes CAMEL-25939. @davsclaus @oscerd # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. _Claude Code on behalf of etzel-mes_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
