allthingssecurity commented on PR #28260: URL: https://github.com/apache/camel/pull/28260#issuecomment-6335450343
Thanks Claus. Pushed ee985a1c2229 on top: 1. recipientList, routingSlip and pollEnrich with `cacheSize=-1`: fixed, not just documented. Those paths don't know the calling exchange, so the removal now also waits until the thread pools that the route's EIPs created (`threads()` and the others) are idle. The component tracks them by route id with `onThreadPoolAdd`/`onThreadPoolRemove`, and the remover checks again every 100 ms. Two new tests (recipientList and routingSlip, `cacheSize=-1`, `pooled` template) fail without it. The javadoc of `removeCreatedRoute` names what is still not covered: a pool that a component creates for itself (async kafka producer) and virtual-thread executors. Shashank has a follow-up JIRA draft for that. 2. The endpoint-registry assertion is inside the `untilAsserted` block (see inline). 3. New 4.24 upgrade-guide entry `camel-kamelet - the route of a Kamelet endpoint is removed with the endpoint`. It says that removing a route added at runtime that consumes from a Kamelet now also removes the Kamelet's route. It also covers the discarded-endpoint case, and says that a route id given in the uri and routes created at startup are not changed. 4. Nested Kamelet with a template parameter in its uri: confirmed by reading the code. `AbstractCamelContext.doRemove` -> `removeEndpoint` only calls `stopService` on the inner `KameletEndpoint`, so its `doShutdown` never runs and the inner route stays. Shashank has a follow-up JIRA draft for it. A possible fix is to start the removal from `LifecycleStrategy.onEndpointRemove`, which `removeEndpoint` already calls. camel-kamelet: 150 tests, 0 failures, 3 skipped. The branch merges cleanly with main and with the other PRs of this batch. The PR description will be updated to match. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
