gnodet-bot commented on code in PR #28275:
URL: https://github.com/apache/camel/pull/28275#discussion_r4346195862


##########
components/camel-azure/camel-azure-eventhubs/src/main/java/org/apache/camel/component/azure/eventhubs/EventHubsEndpoint.java:
##########
@@ -36,6 +39,14 @@
              syntax = "azure-eventhubs:namespace/eventHubName", category = {
                      Category.CLOUD, Category.MESSAGING },
              headersClass = EventHubsConstants.class)
+@BodyTypes(consumerOut = @BodyType(value = Carrier.BYTES, javaType = "byte[]",
+                                   description = "The body of the event, one 
message per event"),
+           producerIn = @BodyType(value = { Carrier.TEXT, Carrier.BYTES, 
Carrier.STREAM, Carrier.FILE, Carrier.LIST },
+                                  description = "What converts to a byte 
array: text, bytes, a stream or a file, sent as one"
+                                                + " event; a Map, a number or 
a POJO fails: marshal it first. A List is sent"
+                                                + " as one event per element, 
in one batch, and an element that is an Exchange"
+                                                + " or a Message is sent with 
its headers"),
+           producerOut = @BodyType(Carrier.UNCHANGED))

Review Comment:
   💡 `producerOut` is the only entry in this PR without a `description` — all 7 
other components provide one (e.g. `"Unchanged"`, `"Unchanged after a send…"`, 
etc.). The generated JSON will have no `description` field for this entry, 
making it inconsistent with its peers in the catalog.
   
   ```suggestion
              producerOut = @BodyType(value = Carrier.UNCHANGED, description = 
"Unchanged"))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to