luigidemasi opened a new issue, #9: URL: https://github.com/apache/camel-kit/issues/9
> Imported from [luigidemasi/camel-kit#13](https://github.com/luigidemasi/camel-kit/issues/13), opened by [luigidemasi](https://github.com/luigidemasi) on 2026-04-30. > Closed on 2026-04-30 without a linked pull request. --- ## Description During the BizTalk migration PR (luigidemasi/camel-kit#12), CodeRabbit flagged several issues in pre-existing code that appeared in the diff due to auto-formatting. These are not regressions from the BizTalk work but genuine issues worth fixing separately. ## Issues ### 1. LTS version detection uses unreliable even-number heuristic **File:** `camel-kit-core/src/main/java/io/github/luigidemasi/camelkit/catalog/CatalogDownloader.java:227` The `getLatestLtsVersion()` method assumes LTS versions have even minor numbers (`minor % 2 == 0`). While this holds for all known Camel 4.x LTS releases (4.0, 4.4, 4.8, 4.10, 4.14, 4.18), the pattern is not officially guaranteed by Apache Camel. Consider maintaining an explicit list of LTS versions or querying the official releases page. ### 2. Fallback version is 4.20.0 **File:** `camel-kit-core/src/main/java/io/github/luigidemasi/camelkit/catalog/CatalogDownloader.java:241` The fallback version when no LTS is found is hardcoded to `4.20.0`. This should track the latest confirmed LTS release or be read from `distribution.properties`. ### 3. Null guard needed before lowercasing error-flow labels **File:** `camel-kit-core/src/main/java/io/github/luigidemasi/camelkit/command/graph/GraphRouteContextCommand.java:66` `s.label()` can return `null` when `properties().get("uri")` or `properties().get("type")` returns null from the graph. Calling `.toLowerCase(Locale.ROOT)` on null will throw NPE. Add a null guard or default to empty string. ### 4. Kafka advertised listener is host-only **File:** `camel-kit-core/src/main/resources/skills/camel-implement/guides/docker-compose.md:174` The Kafka docker-compose template uses `KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://localhost:9092`, which only works for host-network clients. Containerized Camel applications connecting to Kafka via docker-compose networking would fail. Consider adding a dual-listener configuration. ## Context These were flagged by CodeRabbit on PR luigidemasi/camel-kit#12 (review comments luigidemasi/camel-kit#3160643179, luigidemasi/camel-kit#3160643184, luigidemasi/camel-kit#3160643196, luigidemasi/camel-kit#3160643242) but deferred as out of scope for the BizTalk migration work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
