luigidemasi opened a new issue, #49: URL: https://github.com/apache/camel-kit/issues/49
> Imported from [luigidemasi/camel-kit#86](https://github.com/luigidemasi/camel-kit/issues/86), opened by [luigidemasi](https://github.com/luigidemasi) on 2026-05-15. > Closed by [luigidemasi/camel-kit#87](https://github.com/luigidemasi/camel-kit/pull/87), merged on 2026-05-15. --- ## Description Replace the Doubt-Driven Review (DDR) pre-filter in `camel-execute` Step 2b.5 with the [Adversarial Code Review (ACR) pattern](https://asdlc.io/patterns/adversarial-code-review/). The current DDR uses a single doubt-reviewer subagent with a generic adversarial prompt. ACR improves on this with: - **Identity separation** — each Critic Lane runs in its own fresh-context subagent - **Specialized adversarial posture** — each critic has a focused constitution (security, performance, etc.) rather than a generic "find what's wrong" prompt - **Dynamic lane selection** — the Moderator reads the TDD to decide which dimensions to evaluate, replacing the binary triviality gate - **Moderator synthesis** — deduplication and prioritization of findings across critics ## Scope Replace **only** Step 2b.5 (the pre-filter). Spec compliance review (2c) and quality review (2d) remain unchanged. ## Critic Lane Catalogue | Lane | Activates when | |---|---| | Route Architecture | Always | | Security | External system boundaries in TDD | | Performance | Throughput/aggregation/batch in TDD | | Boundary Compliance | Data transformation/mapping tasks | | Behavioral Equivalence | Migration pipelines | ## Files **New:** - `skills/camel-execute/guides/adversarial-code-review.md` - `agents/acr-moderator.md` - `agents/critic-route-architecture.md` - `agents/critic-security.md` - `agents/critic-performance.md` - `agents/critic-boundary-compliance.md` - `agents/critic-behavioral-equivalence.md` **Modified:** - `skills/camel-execute/SKILL.md` — update Step 2b.5 references - `skills/camel-execute/guides/spec-reviewer-criteria.md` — update trade-off source label - `shared/iron-laws.md` — update Iron Law 5 **Deleted:** - `skills/camel-execute/guides/doubt-driven-review.md` ## Attribution Adapts the [Adversarial Code Review pattern](https://asdlc.io/patterns/adversarial-code-review/) from the Agentic Software Development Lifecycle (ASDLC) framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
