apupier commented on PR #28273: URL: https://github.com/apache/camel/pull/28273#issuecomment-6337061943
## Validation — testing done in apupier/camel fork _Bob on behalf of apupier_ The changes were validated using a dedicated fork-test setup before targeting `apache/camel`. Here is what was tested and observed. ### Setup A `fork-test-pr-build` base branch was created in [apupier/camel](https://github.com/apupier/camel) from this branch, with two adjustments needed to make the workflow runnable from a fork: - The `if: github.repository == 'apache/camel'` job guards were removed (they are present on the real branch targeting `apache/camel`). - `fork-test-pr-build` was added to the `branches:` trigger list so that a PR targeting that base branch fires the `pull_request` event. ### Test 1 — normal PR build runs JDK 21 only (no JDK 25) **PR:** [apupier/camel#189](https://github.com/apupier/camel/pull/189) (`ci-test-dummy` → `fork-test-pr-build`, dummy trailing-newline change) **Observed:** only the `build` job (JDK 21) appeared in the checks. The `build-jdk25` job was absent. ✅ ### Test 2 — `workflow_dispatch` with `jdk25_only=true` runs JDK 25 only, does not cancel the PR check **Dispatch run:** [39752467725](https://github.com/apupier/camel/actions/runs/39752467725) triggered against the same PR 189 ref with `jdk25_only=true`. **Observed:** - Only `build-jdk25` ran — the `build` (JDK 21) job was skipped. ✅ - The existing PR check (run [39750338442](https://github.com/apupier/camel/actions/runs/39750338442)) was **not** cancelled. ✅ (An earlier attempt without the `-jdk25` concurrency suffix did cancel it — [39750338442/job/119729033475](https://github.com/apupier/camel/actions/runs/39750338442/job/119729033475?pr=189) — which is why the concurrency group key now appends `-jdk25` when `jdk25_only=true`.) ### Concurrency group keys (final) | Trigger | Group key | |---|---| | `pull_request` on PR N | `Build and test-N` | | `workflow_dispatch` `jdk25_only=true` PR N | `Build and test-N-jdk25` | The two groups are distinct, so they can run simultaneously without interfering with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
