akashSurwase commented on PR #1828:
URL: https://github.com/apache/camel-website/pull/1828#issuecomment-6350241439
> ## TL;DR
> **Request changes**: thanks for the post, @akashSurwase! It's a clear
walkthrough of how `ai-tool`, `langchain4j-agent`, `langchain4j-embeddings` and
`milvus` fit together, and I checked the Camel code shown against Camel 4.22:
the Milvus actions and the `AgentConfiguration` methods are correct, and the
only URI problem is the `parameter.*.type` syntax noted inline. The post isn't
ready to publish yet, though.
>
> **Blockers**
>
> * `index.md:511`, `531`, `596`, `611`, `627`, `645`, `663`: TODO
placeholders. The search-tool route, the Tavily route, the agent REST route, an
example request/response and the Milvus/Tavily config are still missing.
> * `index.md:4`: `draft: true`, so the post is not published.
> * **Length:** please cut the post to about half its length (it is ~5,000
words now, roughly 4x a typical post here) and focus on the Camel part. See
"Length and focus" below.
>
> **Other findings:** 5 non-blocking, plus 1 note about the linked example
repo (details below).
>
> ### Length and focus
> The most interesting part of the post is the Camel side: the two `ai-tool`
routes, how `tags` connect them to the `langchain4j-agent` endpoint, and the
result. Right now that part competes with a lot of setup for other systems.
Could you cut the post to about half its current length and center it on the
Camel routes? Some ideas:
>
> * **Model and Milvus setup** (section 1, and in section 2 creating the
collection, the index, loading it and the verification query): keep a short
paragraph that says what is needed, and move the details into your
`camel-agentic-rag` README, which the post already links to.
> * **Repeated points:** "same embedding model, same vector space" appears
four times, the 768 dimension three times, and the `AgentConfiguration` is
shown in both section 1 and section 4. Explaining each once is enough.
> * **Line-by-line bullets** that restate what the code already says clearly
(for example `setHeader` / `constant(MilvusAction.INSERT)`) can mostly go.
> * **The "Why This Component-Based Design Helps" and Conclusion sections**
cover much the same ground and could be combined.
>
> That way the Camel-specific parts, which few other places on the web cover
yet, stand out, and the TODO sections can be filled in without the post growing
even longer.
>
> ### Notes not tied to a line
> * **`featured.jpg` (non-blocking):** this file is actually a PNG
(1672x941, 1.8 MB) with a `.jpg` extension. Hugo still resizes it for the post
page (I checked with Hugo 0.121), but the `og:image` meta tag points to the
original, so social previews download a 1.8 MB PNG served as `image/jpeg`.
Converting it to a real JPEG, or renaming it to `featured.png`, would fix that.
> * **Linked example repo (`akashSurwase/camel-agentic-rag`):** the "Secure
Tavily API key configuration" commit seems to have swapped the two values.
`application.properties` now has `tavily.api.key=***REMOVED***` and
`tavily.api.url=${TAVILY_API_KEY}`, so `TavilySearchToolRoute` would `toD()`
the API key as the URL and send a literal `***REMOVED***` bearer token. The
`tavily_search` tool won't work for readers who clone it. Something like
`tavily.api.url=https://api.tavily.com/search` and
`tavily.api.key=${TAVILY_API_KEY}` would fix it.
> * **Camel version:** `ai-tool` was added in Camel 4.22 (Preview support
level), and the example uses 4.22.0. Readers on older versions will get "no
component found". It may help to say which Camel version the post needs, and
optionally to link the component pages under `/components/next/` (for example
`https://camel.apache.org/components/next/ai-tool-component.html`). That's your
call as the author.
>
> This is a rules-and-conventions review. It does not replace specialized AI
review tools or static analysis.
>
> _This review was generated by an AI agent and may contain inaccuracies.
Please verify all suggestions before applying._
Thanks for the detailed review and for checking the Camel code. I appreciate
the feedback. I'll shorten the post to focus more on the Camel routes, complete
the missing sections, and address the configuration and other issues you
highlighted. I'll update the existing PR once the changes are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
