davsclaus opened a new pull request, #28330:
URL: https://github.com/apache/camel/pull/28330

   Fixes [CAMEL-26063](https://issues.apache.org/jira/browse/CAMEL-26063).
   
   The `httpMethod` option of camel-vertx-http says "The HttpMethod header 
cannot override this option if set", and camel-http works that way, but 
vertx-http read the `CamelHttpMethod` header first, with the option only as its 
default. So the method of a request that a route received through an HTTP 
consumer, which sets the header, replaced the method of the endpoint.
   
   **Changes**
   - `DefaultVertxHttpBinding`: the method is chosen as in camel-http 
(`HttpMethodHelper.createMethod`): the `httpMethod` option, then the 
`CamelHttpMethod` header, then GET with a query string, POST with a body, else 
GET. The component docs already listed this order.
   - Upgrade guide 4.24: the header no longer overrides the option.
   
   **Tests**
   - `VertxHttpMethodTest.testEndpointConfigurationPrecedenceOverHeader`: an 
endpoint with `httpMethod=DELETE` and the header PUT sends a DELETE; it fails 
without the fix (PUT).
   - The 109 tests of camel-vertx-http pass (1 skipped).
   
   Found while adding the catalog body types of vertx-http (CAMEL-24961).
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to