oscerd commented on PR #28305: URL: https://github.com/apache/camel/pull/28305#issuecomment-6359805403
Pushed one more commit for the review: "CAMEL-25964: Address review feedback - assert the TrustManager that Vert.x applies, and document the TrustManager-over-keystore case". - `VertxHelperTest`: both tests now assert that the `TrustManager` the Vert.x trust options wrap is the configured one (the custom manager, and `TrustAllTrustManager.INSTANCE`), as suggested inline. - Upgrade guide: a second paragraph for the case where both a `TrustManager` and a keystore are set on `TrustManagersParameters` — the `TrustManager` is now used, as in the other components that use `SSLContextParameters`. - Backports (non-blocking point 1): the `camel-4.22.x` and `camel-4.18.x` ports follow once this is merged; the matching notes in the `4.22.2 → 4.22.3` and `4.18.5 → 4.18.6` sections of the guides on `main` come with them, so that `main` does not announce the fix for a release before the port is in. `VertxHelperTest` passes locally (JDK 21). Since the two approvals were given on the previous head, I have re-requested the review. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
