oscerd commented on PR #28274: URL: https://github.com/apache/camel/pull/28274#issuecomment-6359810654
Pushed one more commit for the review: "CAMEL-25918: Address review feedback - document the per-port settings and the asyncMdnAllowedHosts change, javadoc for the MDN constructor". - Component page (and its catalog copy): the settings that still belong to the shared server connection and come from the first endpoint created on the port — `sslContextParameters`/`sslContext`, `mdnMessageTemplate`, `server`, `serverFqdn`, `as2Version` — are now named as per-port settings, next to the paragraph on the per-consumer ones. - Upgrade guide: the `asyncMdnAllowedHosts` change is stated explicitly (inherited list before, delivery to the sender's address without credentials now, set the list on each consumer). - The nine-argument `AS2ConsumerConfiguration` constructor has a javadoc like the five-argument one (gnodet-bot's nit). Documentation and javadoc only; no code change. Re-requested the review since the approval was given on the previous head. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
