allthingssecurity commented on PR #28319: URL: https://github.com/apache/camel/pull/28319#issuecomment-6362609622
@davsclaus thanks for the second review. - Nit: done in 8899d1f4cfaa. The Edge Node producer constructor no longer calls `createClient`; `clientForStart()` in `doStart` takes the client from the map or creates it, as before. An Edge Node producer that is created but never started now leaves no client and executor in the static map. The camel-tahu unit tests pass unchanged (12, 0 failures, among them the 5 of `TahuEdgeProducerRestartTest`). - Rebase: when I checked, `git merge-tree` of the branch against the current main was clean (the upgrade-guide conflict is gone after main moved), and after the push above GitHub still shows the PR as mergeable, so I did not rebase. CI runs on the new head. - Description: it has the upgrade-guide entry, the 5 tests and the `IllegalStateException` for Device sends. - Both follow-ups are in one drafted JIRA, not filed yet: counting the started Edge Node producers (which also fixes the Device send that fails with "no producer of its Edge Node ... is started" while another Edge Node producer runs, and the silent drop of that producer's data), and one lock around the start and stop of an Edge Node so that a starting producer cannot take the future or client that a stop is shutting down. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
