gnodet-bot commented on code in PR #28370:
URL: https://github.com/apache/camel/pull/28370#discussion_r4363013347
##########
dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/DownloadEndpointStrategy.java:
##########
@@ -44,10 +46,27 @@ public Endpoint registerEndpoint(String uri, Endpoint
endpoint) {
if (name != null) {
camelContext.resolveDataFormat(name);
}
+ } else if ("master".equals(scheme) && endpoint instanceof
StubEndpoint) {
Review Comment:
💡 **Optional — `zookeeper-master` has the same gap:**
`zookeeper-master:name:delegateUri` uses the identical URI structure, so the
same stub-skips-delegate bug exists there. Since the PR scopes the fix to
`master` only, consider broadening the guard here to avoid a separate PR later:
```suggestion
} else if (("master".equals(scheme) ||
"zookeeper-master".equals(scheme)) && endpoint instanceof StubEndpoint) {
```
Not blocking — the PR description explicitly calls this out as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
