davsclaus commented on code in PR #28389:
URL: https://github.com/apache/camel/pull/28389#discussion_r4366657890


##########
components/camel-openfeature/src/main/docs/openfeature-language.adoc:
##########
@@ -29,8 +29,8 @@ This language is provided by the `camel-openfeature` 
component:
 
 == Usage
 
-The language evaluates the given flag key as a boolean and returns the
-result. It uses the `openfeature:flags` endpoint by default, inheriting
+As a predicate, the language evaluates the given flag key as a boolean.
+As an expression, it gives the string value of the flag, see below. It uses 
the `openfeature:flags` endpoint by default, inheriting

Review Comment:
   Thanks, fixed in 9179cf71bd14: the Usage section now says the expression 
gives the `defaultValue` of the endpoint (`false` unless set) when the flag is 
missing or is not a string flag. That matches `OpenFeatureEndpoint`, which 
calls `getStringDetails(flagKey, defaultValue, ctx)`. The catalog copy of the 
doc is updated too.
   
   _Claude Code on behalf of davsclaus_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to