gnodet-bot commented on code in PR #27935: URL: https://github.com/apache/camel/pull/27935#discussion_r4374972632
########## components/camel-hibernate/src/main/java/org/apache/camel/component/hibernate/HibernateProducer.java: ########## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hibernate; + +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import org.apache.camel.Exchange; +import org.apache.camel.Expression; +import org.apache.camel.spi.Language; +import org.apache.camel.support.DefaultProducer; +import org.apache.camel.support.SynchronizationAdapter; +import org.hibernate.KeyType; +import org.hibernate.Session; +import org.hibernate.StatelessSession; +import org.hibernate.Transaction; +import org.hibernate.query.MutationQuery; +import org.hibernate.query.SelectionQuery; + +public class HibernateProducer extends DefaultProducer { + + private final HibernateEndpoint endpoint; + private final Map<String, Object> naturalIdParameters = new LinkedHashMap<>(); + + public HibernateProducer(HibernateEndpoint endpoint) { + super(endpoint); + this.endpoint = endpoint; + } + + @Override + protected void doStart() throws Exception { + super.doStart(); + Language simple = endpoint.getCamelContext().resolveLanguage("simple"); + + naturalIdParameters.clear(); + if (endpoint.getNaturalIdParameters() != null) { + endpoint.getNaturalIdParameters().forEach((key, value) -> { + if (value instanceof String str) { + naturalIdParameters.put(key, simple.createExpression(str)); + } else { + naturalIdParameters.put(key, value); + } + }); + } + } + + private Map<String, Object> resolveNaturalIdParameters(Exchange exchange, Map<String, Object> headerParameters) { + Map<String, Object> resolved = new LinkedHashMap<>(); + + naturalIdParameters.forEach((key, value) -> { + if (value instanceof Expression expression) { + resolved.put(key, expression.evaluate(exchange, Object.class)); + } else { + resolved.put(key, value); + } + }); + + if (headerParameters != null) { + // Header values are message data and must never be evaluated as Simple expressions. + resolved.putAll(headerParameters); + } + + return resolved; + } + + @Override + public void process(Exchange exchange) throws Exception { + if (endpoint.isStreaming() && exchange.isTransacted()) { + throw new IllegalArgumentException( + "streaming=true is not supported inside a transacted exchange because streams can outlive route transactions."); + } + + if (exchange.isTransacted() && !endpoint.isJta()) { + throw new IllegalStateException( + "Hibernate producer does not support transacted() exchanges with a resource-local SessionFactory."); + } + + if (endpoint.getStatelessOperation() != null) { + processStateless(exchange); + return; + } + + HibernateSessionContext sessionContext = exchange.getExchangeExtension() + .getSafeCopyProperty(HibernateConstants.HIBERNATE_SESSION_CONTEXT, HibernateSessionContext.class); + + Session session = sessionContext == null + ? null + : sessionContext.getSession( + endpoint.getSessionFactory(), + endpoint.getTenantIdentifier(), + endpoint.getFilters()); + + boolean sessionOwned = session == null; + + if (sessionOwned) { + session = endpoint.getTenantIdentifier() == null + ? endpoint.getSessionFactory().openSession() + : endpoint.getSessionFactory().withOptions() + .tenantIdentifier(endpoint.getTenantIdentifier()) + .openSession(); + } + + final Session activeSession = session; + final Transaction transaction = sessionOwned + ? activeSession.beginTransaction() + : activeSession.getTransaction(); + + try { + if (sessionOwned && endpoint.getFilters() != null) { + endpoint.getFilters().forEach((filterName, parameters) -> { + var filter = activeSession.enableFilter(filterName); + if (parameters != null) { + parameters.forEach(filter::setParameter); + } + }); + } + + @SuppressWarnings("unchecked") + Map<String, Object> parameters = exchange.getMessage().getHeader( + HibernateConstants.HIBERNATE_PARAMETERS, Map.class); + + if (endpoint.getNaturalIdParameters() != null + && !endpoint.getNaturalIdParameters().isEmpty()) { + Object entity = activeSession.find( + endpoint.getEntityType(), + resolveNaturalIdParameters(exchange, parameters), + KeyType.NATURAL); + + exchange.getMessage().setBody(entity); + + if (sessionOwned) { + transaction.commit(); + activeSession.close(); + } + } else if (endpoint.getSelectionQuery() != null) { Review Comment: ⚠️ **`selectionQuery` null vs blank check mismatch** `HibernateEndpoint.doStart()` uses `!= null && !isBlank()` to determine whether a selection query is configured. This dispatch branch uses only `!= null` — a blank-but-non-null `selectionQuery` falls into the selection branch and calls `createSelectionQuery("")` instead of falling through to the mutation path. The two guards must match: ```suggestion } else if (endpoint.getSelectionQuery() != null && !endpoint.getSelectionQuery().isBlank()) { ``` ########## components/camel-hibernate/src/main/java/org/apache/camel/component/hibernate/HibernateConsumer.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.hibernate; + +import java.util.List; + +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.support.ScheduledPollConsumer; +import org.hibernate.LockMode; +import org.hibernate.Session; +import org.hibernate.Timeouts; +import org.hibernate.Transaction; +import org.hibernate.query.SelectionQuery; + +public class HibernateConsumer extends ScheduledPollConsumer { + + private final HibernateEndpoint endpoint; + + public HibernateConsumer(HibernateEndpoint endpoint, Processor processor) { + super(endpoint, processor); + this.endpoint = endpoint; + } + + @Override + protected void doStart() throws Exception { + if (endpoint.getSelectionQuery() == null || endpoint.getSelectionQuery().isBlank()) { + throw new IllegalArgumentException("Hibernate consumer requires selectionQuery"); + } + super.doStart(); + } + + @Override + protected int poll() throws Exception { + if (endpoint.getSelectionQuery() == null || endpoint.getSelectionQuery().isBlank()) { + throw new IllegalArgumentException("Hibernate consumer requires selectionQuery"); + } + + Session session = endpoint.getTenantIdentifier() == null + ? endpoint.getSessionFactory().openSession() + : endpoint.getSessionFactory().withOptions() + .tenantIdentifier(endpoint.getTenantIdentifier()) + .openSession(); + + try (session) { + Transaction transaction = session.beginTransaction(); + + try { + if (endpoint.getFilters() != null) { + endpoint.getFilters().forEach((filterName, parameters) -> { + var filter = session.enableFilter(filterName); + if (parameters != null) { + parameters.forEach(filter::setParameter); + } + }); + } + + SelectionQuery<?> query = session.createSelectionQuery( + endpoint.getSelectionQuery(), endpoint.getEntityType()); + + if (endpoint.isReadOnly()) { + session.setDefaultReadOnly(true); + query.setReadOnly(true); + } + + if (endpoint.getMaximumResults() > 0) { + query.setMaxResults(endpoint.getMaximumResults()); + } + + if (endpoint.isSkipLocked()) { + query.setHibernateLockMode(LockMode.PESSIMISTIC_WRITE); + query.setLockTimeout(Timeouts.SKIP_LOCKED); + } + + List<?> results = query.getResultList(); + + for (Object result : results) { + Exchange exchange = null; + try { + exchange = createExchange(false); + exchange.getMessage().setBody(result); + HibernateSessionContext sessionContext = new HibernateSessionContext( + session, + endpoint.getSessionFactory(), + endpoint.getTenantIdentifier(), + endpoint.getFilters()); + + exchange.getExchangeExtension().setSafeCopyProperty( + HibernateConstants.HIBERNATE_SESSION_CONTEXT, sessionContext); + + getProcessor().process(exchange); + + if (exchange.getException() != null) { + throw exchange.getException(); + } else if (endpoint.isConsumeDelete()) { + session.remove(result); Review Comment: ⚠️ **Rollback-only exchange silently consumes the entity** `exchange.getException() != null` does not catch exchanges marked rollback-only via `markRollbackOnly()` or `markRollbackOnlyLast()` — those have no exception set. The entity is removed and the transaction committed, silently ignoring the rollback intent. `camel-jpa`'s `JpaConsumer.java` handles this explicitly with `isRollbackOnly()` checks. ```suggestion if (exchange.getException() != null) { throw exchange.getException(); } else if (exchange.isRollbackOnly() || exchange.isRollbackOnlyLast()) { throw new org.apache.camel.RollbackExchangeException( "Rollback poll transaction: exchange marked rollback only", exchange); } else if (endpoint.isConsumeDelete()) { session.remove(result); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
