davsclaus commented on PR #28352: URL: https://github.com/apache/camel/pull/28352#issuecomment-6412333427
## TL;DR **Approve** - keying the multiplex channel handlers by the listener address fixes the cross-interface dispatch, and f9aa2d20 addresses every point from the first round. **Blockers** - None **Other findings:** none. Re-checked on f9aa2d20: - `NettyHttpDifferentHostSamePortTest` is skipped on macOS, so `mvn test` in the module works on a Mac and CI on Linux still runs it. - The unused `getMultiplexChannelHandler(String)` overload is gone; both call sites use `(address, port)`, the same `getAddress()` key as `bootstrapFactories` (which is also the socket path for a Unix domain socket consumer, so those stay separate too). - The deprecated `getMultiplexChannelHandler(int)` documents that it only returns the `0.0.0.0` handler, and nothing in Camel calls it. - `doStop()` still stops and clears every handler in the map, so the extra per-address entries are cleaned up. I resolved the six review threads, since each one is addressed in f9aa2d20. This review checks the PR against the project rules and conventions; it does not replace static analysis or other review tools. _Claude Code on behalf of davsclaus._ _This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
