Croway opened a new pull request, #28503: URL: https://github.com/apache/camel/pull/28503
Jira: https://issues.apache.org/jira/browse/CAMEL-25984 Backport of #28283 to `camel-4.18.x` (cherry-pick of b7064881cc29). With `crossOriginFilterOn=true`, the CORS filter now allows credentials only when `allowedOrigins` lists the origins explicitly, without any entry containing `*` and without an entry `null`. When `allowedOrigins` is not set, is `*`, or has such an entry, the origin is still allowed, but without credentials. - The only conflict was `camel-4x-upgrade-guide-4_24.adoc`, which does not exist on this branch, so it is left out. The upgrade guide entry for 4.18.6 is added on `main` in a separate doc-sync PR. - `CometdCrossOriginFilterTest`: the `HttpClient` is no longer in a try-with-resources, since `HttpClient` is `AutoCloseable` only from Java 21 and this branch builds with `release 17` (as noted in the review of #28283). The test extends the `camel-test-junit5` `CamelTestSupport`, which this branch uses. Tests: `components/camel-cometd` `./mvnw -Psourcecheck verify` on this branch: BUILD SUCCESS, 21 tests, 0 failures (6 in `CometdCrossOriginFilterTest`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
