etzel-mes commented on PR #28387:
URL: https://github.com/apache/camel/pull/28387#issuecomment-6415200987
@gnodet thanks, the write path is fixed in
a214ef9ebc1ae1fdbd441c5ab74ecc4c3303be29: `buildPlcWriteRequest(Map)` now reads
`connection` once and throws `PlcConnectionException("Cannot establish
connection")` when it is null, like `buildPlcReadRequest(Map)`. Besides the
race with `doStop()`, this also replaces the NullPointerException a producer
got when `reconnectIfNeeded()` had stopped the endpoint with
`autoReconnect=false`.
`Plc4XEndpointTest.buildPlcWriteRequestWithoutAConnection` covers it.
I left `getTags()` as it is. It returns the option field like the other
endpoint getters, and the generated `Plc4XEndpointConfigurer` reads the option
through it, so I would rather not change it in this PR.
Module build with tests and `-Psourcecheck`: 38 tests, 0 failures. The
branch was also rebased onto main (afa62bc19ec) to resolve a conflict in the
4.24 upgrade guide; both sections are kept.
_Claude Code on behalf of etzel-mes_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
