oscerd commented on PR #28512:
URL: https://github.com/apache/camel/pull/28512#issuecomment-6416414090
Addressed review feedback:
• `InMemorySessionStore.getSession()`: changed `log.warn("No OAuthSession
for: {}", sessionId)` to `log.warn("No OAuthSession found for cookie")` to
ensure raw session cookie values are not logged.
• `InMemorySessionStore.rotateSession()`: changed debug log to
`log.debug("Rotated OAuthSession")` to avoid logging old and new session IDs.
• `OAuthSessionStore.rotateSession()`: added `@implNote` warning
implementors that custom stores must override `rotateSession` to prevent
session fixation.
• `InMemorySession`: restricted visibility of `getValues()` and
`putAll(...)` to package-private.
• `OAuth.rotateSession()`: added Javadoc documenting delegation to
`OAuthSessionStore`.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
