oscerd commented on PR #28214:
URL: https://github.com/apache/camel/pull/28214#issuecomment-6417188917
Addressed in the latest push:
1. Transport and connection errors in `AbstractSftpConsumer` are now
distinguished from missing/unresolvable symlink targets and rethrown to fail
the poll cleanly instead of silently skipping the file.
2. In `GenericFileConsumer`, unresolvable symlinks are now tracked and
logged as "symbolic link cannot be resolved" rather than falsely reported as
resolving outside the starting directory.
3. Updated `quotePathForJsch` Javadoc to use functional wording.
4. Added integration test variants for `stepwise=false`
(`skipsLinkResolvingOutsideStartingDirectoryStepwiseFalse` and
`skipsDanglingLinkStepwiseFalse`) and recursive subdirectory symlink resolution
(`skipsLinkResolvingOutsideInSubDirectoryRecursive`) in both `camel-ftp` and
`camel-mina-sftp`. Note regarding home-relative paths: in Camel SFTP, starting
directory paths are inherently relative to the home/working directory (as
enforced by `FtpUtils.ensureRelativeFtpDirectory`, absolute starting
directories are not supported and have their leading slash stripped), so
`endpointPath` is already relative in the ITs and exercises
`getHomeDirectory()` (`ChannelSftp.getHome()` in `camel-ftp` and
`SftpClient.canonicalPath(".")` in `camel-mina-sftp`) against the real server.
5. Rebased cleanly onto latest `main`.
6. Point 1 (retrieval-side JSch globbing) remains tracked separately in the
private tracker as agreed.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
