Croway commented on PR #2062:
URL: 
https://github.com/apache/camel-spring-boot/pull/2062#issuecomment-6420872990

   _Claude Code on behalf of Federico Mariani_
   
   Let's hold off on this until Camel core moves to Surefire 3.6.x as well 
(apache/camel `main` is still on 3.5.6), so the two projects stay aligned.
   
   Heads-up for whoever picks this up: starting with 3.6.0 
([SUREFIRE-823](https://issues.apache.org/jira/browse/SUREFIRE-823), 
apache/maven-surefire#3371), `-DskipTests` **no longer skips Failsafe 
integration tests**. Only `-DskipITs` or `-Dmaven.test.skip` do.
   
   This affects us because Failsafe's version is managed through 
`${maven-surefire-plugin-version}` (inherited from the Camel root POM 
pluginManagement), so this bump upgrades Failsafe too. Several starters (e.g. 
kafka, mongodb, cassandraql, consul, infinispan) and 
`tests/camel-itest-spring-boot` bind Failsafe in the default build. Builds 
using `-DskipTests`, including `.github/workflows/automatic-sync-main.yml` and 
`.github/workflows/generate-sbom-main.yml`, would then start running the 
Testcontainers-based ITs.
   
   When we upgrade, we need one of:
   - update the Failsafe pluginManagement to set 
`<skipITs>${skipTests}</skipITs>`, or
   - add `-DskipITs` wherever we rely on `-DskipTests`.
   
   (`-Dfastinstall` and the Jenkins deploy job use `maven.test.skip.exec` and 
are not affected; the `release` profile already sets `skipITs`.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to