allthingssecurity commented on PR #28531: URL: https://github.com/apache/camel/pull/28531#issuecomment-6430887237
@gnodet thanks for the review. - **`hasTrait` guard**: done in f5dad26918a3, in both `ReplyManagerSupport` classes (camel-jms and camel-sjms). They now use the same pattern as `AbstractExchange.newOutMessage()`: `hasTrait(MessageTrait.ATTACHMENTS)`, then the null check, then a `LinkedHashMap` copy. Behaviour is the same. camel-jms unit tests: 456 + 16 + 6 run, 0 failures, 11 skipped. camel-sjms: 141 run, 0 failures, 5 skipped. Both use the embedded Artemis broker. The two new `*InOutKeepsAttachmentsTest` classes pass. - **`SjmsMessage.copyFrom`**: confirmed on main. It overrides `DefaultMessage.copyFrom` without calling super and copies the JMS message, message id, body and headers, but not the `ATTACHMENTS` trait, which `JmsMessage.copyFrom` copies since #28083. `Message.copy()` goes through `copyFrom`, so an exchange copy (Multicast, Splitter, WireTap) of an sjms message loses its attachments. I left it out of this PR and noted it as a follow-up JIRA candidate. - **Backport labels**: I can't set labels on apache/camel (no permission). The description lists the branches (camel-4.23.x and camel-4.22.x have the same reply managers). A committer can add the `port/` labels when merging. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
