allthingssecurity commented on PR #28539: URL: https://github.com/apache/camel/pull/28539#issuecomment-6430887918
@gnodet thanks for the review. Pushed 551c5e264637 (design/chaos.adoc only): - **Default on**: I kept `camel.chaos.enabled=true`, as CAMEL-26330 asks for hooks that wait idle when the JAR is on the classpath, and took your second option: with no rules the hooks do nothing. The doc now says it as a decision. A fault needs both the JAR and a rule, and the hooks are installed with profile `dev` or no profile and never with `prod`. - **Rule syntax**: new subsection under Rules. It gives the parameters of each fault (`error` with `exception`, `message`, and `status` / `header.<name>` for the HTTP components; `delay` and `stall` with `duration`; `drop`; `corrupt` with `mode`; `lifecycle` with `action=suspend|stop|remove`), plus `rate` and `until`. Examples for `camel.chaos.rules` and `camel cmd chaos add`. It replaces the dangling "see below". - **`corrupt`**: now defined. It means the message faults of the Messages row: header values with random data, a body in an unusual charset, an `InputStream` that ends too soon (`mode=headers|charset|truncate`). The Hooks table names the fault type in each row. - **`insecure:dev`**: now a decision. `camel.chaos.rules` gets `@Metadata(security = "insecure:dev")`, as `devConsoleEnabled` has in `DefaultConfigurationProperties`, so profile `prod` (which sets `camel.security.policy=fail`) refuses to start with rules configured. One detail I found while checking: `SecurityUtils.isInsecureValue` compares the value with a single insecure value, which works for boolean flags only. The doc says the module PR extends it so that any non-empty value of a String option counts. - **Open questions**: each now has a "Proposed:" answer (`components/camel-chaos`; no profile allowed, as above; the one-line text form, YAML later if wanted). I kept the section, though. The doc is at status `proposed`, and these are for Claus to decide, not for me to close. - **`approvers: []`**: kept. It is what the other docs do. `design/payload-mode.adoc` (#28457, also `proposed`) has `approvers: []`, and so do the merged `aiResource`, `aiTool`, `headers`, `java-dsl-parser`, `security` and `cross-cutting-binding` docs. Only `mdc` and `tracing`, both `implemented`, list approvers. The doc is now about 17 KB. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
