oscerd commented on PR #28553: URL: https://github.com/apache/camel/pull/28553#issuecomment-6438232644
Thanks @davsclaus! All points addressed: 1. **Header mapping dropped**: Dropped mapping `CamelMinioServerSideEncryption` to `x-amz-server-side-encryption` in `determineExtraHeaders` and removed `putObjectWithServerSideEncryptionHeader` test. Header-driven encryption can be designed separately if needed. 2. **Mutual exclusion in `doStart()`**: Moved the check to `MinioProducer.doStart()`, failing fast on startup and removing the duplication from `doPutObject` and `copyObject`. Replaced per-operation throw tests with `producerStartWithBothEncryptionOptionsThrows`. 3. **Upgrade guide**: Added a section in `camel-4x-upgrade-guide-4_24.adoc` explaining that `serverSideEncryption` and `serverSideEncryptionCustomerKey` now apply to `MinioProducer` and detailing the startup failure when both are configured. 4. **Consumer copy alignment**: Agreed that aligning `MinioConsumer.moveAfterRead` to encrypt the destination with `serverSideEncryptionCustomerKey` when configured makes sense. We will create a follow-up issue for that. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
