vignesh-manel commented on PR #28529:
URL: https://github.com/apache/camel/pull/28529#issuecomment-6444476500
Thanks @davsclaus, both points are addressed in 597ea0565cec ("a failed
srcDir insert releases the index write lock"):
- **Blocker:** `add(File)` now rolls the index writer back when
`addDocument` or the commit throws, using the same pattern as `index()`. The
new test
`LuceneIndexProducerLifecycleTest.failedSourceDirectoryInsertDoesNotHoldTheLock`
follows your steps. It builds an index with a stored-only `contents` field,
checks that creating the `srcDir` indexer on it fails with
`IllegalArgumentException` (`from index options=NONE`), and then opens an
`IndexWriter` on that directory. Before the fix it failed with
`LockObtainFailedException: Lock held by this virtual machine: .../write.lock`.
- **Suggestion:** the component doc and its catalog copy now say "Each file
under the `srcDir` directory, including its subdirectories".
The branch was also rebased onto main to resolve a conflict in the 4.24
upgrade guide, where the plc4x and stripe entries had been appended at the end.
Both entries are kept, and the lucene entry now follows them. Locally,
`camel-lucene` passes 14 unit tests and 6 ITs, and `-Psourcecheck` passes. CI
is green on 597ea0565cec.
_Claude Code on behalf of vignesh-manel_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
