ansh0014 commented on PR #6920: URL: https://github.com/apache/camel-k/pull/6920#issuecomment-6447107683
Hi @squakez, Thanks for the review! I have addressed all the feedback in the latest commit: 1. **Moved `kafka-ephemeral.yaml`**: Relocated from `setup/` to `files/`. 2. **Simplified `setup.sh`**: It now strictly installs the shared KEDA operator; all broker services are removed from setup. 3. **Controlled at test level**: `TestKafkaKedaAutoscale` now manages the lifecycle of the ephemeral Kafka deployment directly (applying, waiting for rollout readiness, and cleaning up at test completion). 4. **Cleaned up test logic**: Removed all `defer` blocks in favor of standard in-test cleanup. 5. **Preserved original source comments & licenses**: Added back full ASF headers and maintenance comments across all files in `files/`. The PR is updated and ready for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
