Croway commented on PR #28582:
URL: https://github.com/apache/camel/pull/28582#issuecomment-6449976406
Thanks @davsclaus, all addressed in new commits on top (no force-push):
1. **Publish vs `--check` on `latest`.** Fixed in 7fe881d41028. In publish
mode, a version that would become the highest without `--latest true` now fails
before anything is written: no `X.Y.Z.properties`, no aliases, no
`install.sha256`. The error is `Error: 4.23.0 is higher than every published
release (highest is 4.22.0), so latest.properties must move to it - pass
--latest true.` An empty releases directory is still accepted, because
`camel-package.sh` stages into a fresh directory.
2. **`camel-package.sh`.** It now passes `--lts true` for `--channel lts`
(7fe881d41028), and `--print-plan` shows `WEBSITE_LTS`. The staging output is
not what the website publishes (the website runs its own script against
Central), but now it is consistent.
3. **Refusal messages.** Fixed in d7087680370a + 85f6b1857786. A
selector-pinned install that refuses `--version` now says `this install is
pinned to LTS` (or `pinned to the 4.22 release line`) and suggests re-running
the installer with `--version X.Y.Z` to pin an exact version, showing the `curl
... | sh -s -- --version` / `install.ps1 -Version` command. It no longer
suggests removing the pin file. The exact-pin message is unchanged.
4. **Nits.**
- `InstallDetector.pinnedVersion` javadoc updated (8ff63dc4bc67).
- Added `trailingZeroReleaseLineIsNotReadAsAShorterLine` to both the
POSIX and Windows installer tests: `--version 4.20` installs 4.20.x, and line
`4.2` rejects 4.20.0 / 4.22.0. `install.ps1` compares with
`StartsWith("$Version.")` including the dot, so it was already correct. The
Windows variant runs on Windows CI only.
Re-tested before pushing:
- `camel-launcher` unit tests: 291, 0 failures (36 Windows-only skipped).
- End to end in a container against a local fake site, published step by
step with this generator: 17 cases, all passing. These include publishing the
new highest version without `--latest` (rejected, nothing written) and the new
refusal wording for LTS and line pins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
