allthingssecurity commented on PR #28590: URL: https://github.com/apache/camel/pull/28590#issuecomment-6464851603
@davsclaus thanks, done in 6a099bd759a6 (one new commit on top). **Blocker.** The exception reply now passes `out != null ? out : new DefaultMessage(exchange)`, so a reply with no QoS headers gets the endpoint's priority and delivery mode. New test: a consumer with `preserveMessageQos=true&transferException=true&priority=7&deliveryPersistent=false` throws, and the reply that arrives on the `JMSReplyTo` queue has priority 7, is `NON_PERSISTENT` and carries the `IllegalStateException`. On the previous head it gets `4 == 7`. **Non-blocking** 1. With `preserveMessageQos`, both templates now get the endpoint's priority, delivery mode and time to live even when `explicitQosEnabled=false`, as camel-jms does. The template reads its own `explicitQosEnabled` only when preserve is off, so nothing else changes. Test: `priorityAndDeliveryModeOfTheEndpointAreUsedWithExplicitQosDisabled`, which fails on the previous head with `4 == 7`. 2. I put a comment back in `resolveDeliveryMode`: the binding never sets that property, and the branch is only kept for a JMS message that carries it. 3. I left the `priority` description as it is. Changing it means regenerating the sjms and sjms2 metadata, the catalog and the endpoint DSL. The upgrade guide covers the `preserveMessageQos` fallback. I can do it here if you prefer. The guide now also says that a normal reply keeps the QoS headers of the request unless the route changes them, and that an exception reply uses the endpoint's values. camel-sjms: 150 run, 0 failures, 5 skipped. camel-sjms2: 23 run, 0 failures. I updated the description to match. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
