allthingssecurity commented on PR #28596: URL: https://github.com/apache/camel/pull/28596#issuecomment-6465240715
@davsclaus thanks. The replay follow-up is already filed as [CAMEL-26107](https://issues.apache.org/jira/browse/CAMEL-26107) (linked to CAMEL-26088), and its PR goes up tomorrow. It covers both parts of your first point: - **`TRUNCATE_EXISTING` before `loadCache()`:** `start()` now reads the unconfirmed entries of the existing log before it creates the writer, and carries them over into the new log. - **`LogReader.doReadEntry` position:** the replay now goes through the same path as a new offset, so the position of a `PersistedLogEntry` is no longer used. `LogWriter.updateState(PersistedLogEntry, ...)` and that position stay in the public API, but nothing in the component calls them any more. If you prefer, I'll fix the position there too, in that PR or a separate one. Agreed that no backport is needed, since the corruption has no visible effect today. I'll fold your suggestions 2 and 3 (the slot check and the `position >= 0` guard) and the two nits into this PR if CI needs another run anyway; otherwise into CAMEL-26107. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
