apupier opened a new pull request, #28614:
URL: https://github.com/apache/camel/pull/28614
Two tests are flaky on CI:
- NatsConsumerPushConsumerDeletedTest
.removesItsConnectionListenerWhenTheRouteStopsWhileItSubscribes
("no keeper listens to the connection after the stop ==> expected: <[]>
but was: <[NatsJetStreamPushConsumerKeeper@...]>")
- NatsConsumerJetStreamPushStopTest
.stopWhileSubscribingIsNotReportedAsAnError ("no subscription left once the
consumer stopped ==> expected: <0> but was: <1>")
Cause: the consumer submits its first subscribe on its own executor in
doStart(), so it runs asynchronously. Both tests started to change the state of
the consumer (replace the route, install the beforeSubscribe hook, stop and
start the consumer) without waiting for that first subscribe to complete. The
first subscribe could then overlap with the steps of the test, or consume the
one-shot hook meant for the next subscribe, and leave behind a connection
listener or an active subscription that nothing ends.
Fix (test only, no production change): each test now first waits, with
Awaitility and an explicit atMost, until the first subscribe is done (a
connection listener is registered, respectively one subscription is active).
Verification, running each of the two test methods 10 times in a row (mvn
test -Dtest=...) on the local machine:
- without the fix: removesItsConnectionListener... failed 7 times out of 10
(runs 2, 3, 5, 6, 7, 9 and 10, with the exact message of the JIRA; most were
passed by the surefire rerun and reported as flakes).
stopWhileSubscribingIsNotReportedAsAnError did not fail in 10 runs, so it could
not be reproduced locally: the wait added for it follows from the analysis of
the code and from the identical pattern of the other test, and was not
confirmed by a local failure. It is likely to need a slower or loaded machine
like CI to show up.
- with the fix: 0 failures out of 10 runs for both tests.
Co-authored-by: IBM Bob 2.2.1
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
